Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Think about best way to derive ADT Sum types #3

Closed
AugustNagro opened this issue Feb 18, 2021 · 0 comments · Fixed by #10
Closed

Think about best way to derive ADT Sum types #3

AugustNagro opened this issue Feb 18, 2021 · 0 comments · Fixed by #10

Comments

@AugustNagro
Copy link
Member

scala/scala3#11048

Maybe it's best to go back to caching child NativeConverters, and serializing w/ String ElemLabel. Right now it's just try-cache.
AugustNagro added a commit that referenced this issue Mar 22, 2021
@AugustNagro
Improved Sum Type Conversion
6606aad 
* No more try-catch during fromNative
* fromNative requires a "@type" property that equals the (short) name of the type to deserialize
* toNative adds a "@type" property automatically
* Simple Sum types continue to serialize/deserialize their type names as Strings.

Resolves #3
AugustNagro added a commit that referenced this issue Mar 22, 2021
@AugustNagro
Improved Sum Type Conversion
e322b4f 
* No more try-catch during fromNative
* fromNative requires a "@type" property that equals the (short) name of the type to deserialize
* toNative adds a "@type" property automatically
* Simple Sum types continue to serialize/deserialize their type names as Strings.

Resolves #3
@AugustNagro AugustNagro mentioned this issue Mar 22, 2021
Merged
AugustNagro added a commit that referenced this issue Mar 22, 2021
@AugustNagro
Improved Sum Type Conversion
da58292 
* No more try-catch during fromNative
* fromNative requires a "@type" property that equals the (short) name of the type to deserialize
* toNative adds a "@type" property automatically
* Simple Sum types continue to serialize/deserialize their type names as Strings.

Resolves #3
AugustNagro added a commit that referenced this issue Mar 22, 2021
@AugustNagro
Improved Sum Type Conversion
869db25 
* No more try-catch during fromNative
* fromNative requires a "@type" property that equals the (short) name of the type to deserialize
* toNative adds a "@type" property automatically
* Simple Sum types continue to serialize/deserialize their type names as Strings.

Resolves #3
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved Sum Type Conversion getshaka-org/native-converter
1 participant
@AugustNagro