Add checkdeps #418
Merged
Add checkdeps #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjharder
force-pushed
the
add-checkdeps
branch
2 times, most recently
from
a0faa33
to
1deba72
Compare
|
Thanks a lot @davidjharder! Everything looks good. I just need to give a little think on what wording I want to use for the "packaging practice" section. Would you mind if I take over/commandeer this PR from now on? Edit: you don't need to do anything. I just don't want to push before letting you know and then cause you to lose existing work you may have done locally. |
|
@GZGavinZhao I've committed all my work on this. Feel free to commandeer the PR. |
|
@GZGavinZhao - I'm changing this to Draft status since it looks like you want to add to it before it merges. If this is incorrect, my apologies. |
|
Hey @GZGavinZhao , do you mind if I merge this? |
davidjharder
force-pushed
the
add-checkdeps
branch
from
1deba72
to
7f9ff36
Compare
|
No problem, go ahead! Thanks for finishing this! |
davidjharder
force-pushed
the
add-checkdeps
branch
from
7f9ff36
to
49c9c2a
Compare
Add info about checkdeps to the following pages: - packaging changes - package.yml - packaging-practices (just a stub for now)
davidjharder
force-pushed
the
add-checkdeps
branch
from
49c9c2a
to
207c80b
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add info about checkdeps to the following pages:
Fixes #417