Add checkdeps field to package.yml #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joebonrichie
requested changes
Oct 22, 2023
GZGavinZhao
force-pushed
the
checkdeps
branch
from
9899eeb
to
54e3265
Compare
Signed-off-by: Gavin Zhao <git@gzgz.dev>
GZGavinZhao
force-pushed
the
checkdeps
branch
from
54e3265
to
ad06148
Compare
joebonrichie
approved these changes
Oct 22, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing still needed.Tested withpython-packagingand the checkdeps were installed just as builddeps.Ideally, we can further improve upon this by emitting a warning if a checkdep appears in the final rundeps or duplicates with a builddep, but that can be put into a separate PR.
Once this is merged, I will add relevant documentation to the help center.