Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

rc.yml: Provide cargo_{fetch,build,install,test} macros #52

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

joebonrichie
Copy link
Contributor

@joebonrichie joebonrichie commented Dec 23, 2023

For setup, build, install and check steps respectively.

@ReillyBrogan
Copy link
Contributor

Perhaps you could have it automatically pull in cargo as a builddep?

@ReillyBrogan
Copy link
Contributor

So that's not actually possible, I was getting it confused with boulder.

Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's mirror the macros just landed in Serpent here for consistency?

cf. https://github.com/serpent-os/boulder/blob/main/data/macros/actions/cargo.yml

@ermo ermo added the enhancement New feature or request label Feb 27, 2024
For setup, build, install and check steps respectively.
@joebonrichie joebonrichie changed the title rc.yml: Provide cargo_{fetch,build} macros rc.yml: Provide cargo_{fetch,build,install,test} macros Mar 5, 2024
Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@ermo ermo merged commit dddf3da into master Mar 5, 2024
@ermo ermo deleted the cargo-macros branch March 5, 2024 14:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants