Update examples to include age-encryption #1031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajvb
reviewed
Mar 22, 2022
| @@ -1,31 +1,31 @@ | |||
| myapp1: ENC[AES256_GCM,data:zlGNmhTYX5xol4ZZFsiaoGkD73nn,iv:ql9mkhoU1I64E/FJi3iA0HaAe2U3kQVFee2ZLwPnBik=,tag:SqVSfu/JkRrwqidAT/i0pg==,type:str] | |||
| myapp1: ENC[AES256_GCM,data:KhLDS2R2H/BH32vUit2BGhNONIq8,iv:onHYft9ubwdfdwOOsO9yET9xe6x3UHGl+Ov/LApkCmU=,tag:dzjQG/MOmlGZjMGPhqXIvQ==,type:str] | |||
There was a problem hiding this comment.
We might want to retain the former example.yaml as example.pgp.yaml or similar. And then modify the Test with the dev PGP key section in the README.
| "firstName": "ENC[AES256_GCM,data:f8++3g==,iv:rYuVzzb+C40QlYgO4Dl2V7atZUx0ITBcyb5fUsftKMo=,tag:krquPqa1HQltZqidzNamrA==,type:str]", | ||
| "lastName": "ENC[AES256_GCM,data:94a2Q8c=,iv:c3NC7L80UTtbz7gdvPV5oSUwg30lC3Kg82uvRVs5CZw=,tag:kUXRNerUWmSe44mwD4w5uA==,type:str]", | ||
| "age": "ENC[AES256_GCM,data:gjwWkw==,iv:XEWFpsyvEsPwr3qqsOJlfZ+vSZdiA+D6DAc6aoq/BS0=,tag:pcnUyMtYFa9v5DB6sNV15w==,type:float]", | ||
| "firstName": "ENC[AES256_GCM,data:BI/mJA==,iv:ZojqEcQXP8/LyABBbQvcdzY/4PGmR8Q1E8A/b/RtEQk=,tag:YlyRWpnno1rh3f8/+aZa+Q==,type:str]", |
There was a problem hiding this comment.
Same as with example.json, this file is referenced in it's current state within the README. Can just swap with example.pgp.json or similar.
| @@ -182,7 +182,23 @@ the ``--age`` option or the **SOPS_AGE_RECIPIENTS** environment variable: | |||
|
|
|||
| .. code:: bash | |||
|
|
|||
| $ sops --encrypt --age age1yt3tfqlfrwdwx0z0ynwplcr6qxcxfaqycuprpmy89nr83ltx74tqdpszlw test.yaml > test.enc.yaml | |||
| # encrypt | |||
| $ sops --age age1yt3tfqlfrwdwx0z0ynwplcr6qxcxfaqycuprpmy89nr83ltx74tqdpszlw -e test.yaml > test.enc.yaml | |||
There was a problem hiding this comment.
I'd rather leave the -e and -d as the first flag. That ordering is how it's used throughout the rest of the README
| -----END AGE ENCRYPTED FILE----- | ||
| lastmodified: "2022-03-15T22:11:15Z" | ||
| mac: ENC[AES256_GCM,data:dwrqrNqt0F0lNkPv/T16GzC57nGmHo/frkdYvsUM/Izfqd7F7t1FUs6sILmz1o6lKllkADL3+A5DISSsaYK05RYr2RuCtZ7V+XC1JKD+loJoo1CAwcHAjGkv/Jv2Y7ePd6tXr6Fb+BuFVQIpwmI5ze3DsKqUd7bQ+DfRRpr9IoA=,iv:9Y2ASpFstcE8ZgwzOvb3oMQsd30Rukd7gvOb7lMvV1o=,tag:qXQosmzw6UoOXFI+8IvtXg==,type:str] | ||
| pgp: [] |
There was a problem hiding this comment.
Why is pgp empty when there are still pgp keys in the .sops.yaml? I'm guessing they just weren't used, but we should keep them or remove the pgp keys in the .sops.yaml.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this
comment It was suggested to split the original PR #966 into two.
This change will re-encrypt all example files with age as well in the
hopes to drive age adoption.
This is a follow up to #966