Ensure stable order of SOPS parameters in dotenv file #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! |
|
Aww, why did you close it? :( (Aside from the 7 months of it being ignored) |
|
👍 to re-open - would be nice to have this fix! |
hiddeco
approved these changes
Aug 14, 2023
Signed-off-by: Andraz Bajt <andraz@bajt.me>
edofic
force-pushed
the
issue565/sort-dotenv-sops-params
branch
from
d544170 to
700eea7
Compare
|
@hiddeco I've rebased and signed-off the second commit 👍 |
hiddeco
approved these changes
Aug 16, 2023
hiddeco
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #565 by sorting the parameters as suggested by @autrilla (implementation by @Jdban)
Built on top of #575
The test reliably fails if I comment out line 106
sort.Strings(keys)