Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

gcpkms: fix WithCredentialsJSON to credentials #1214

Closed
wants to merge 1 commit into from
Closed

gcpkms: fix WithCredentialsJSON to credentials #1214

wants to merge 1 commit into from

Conversation

zchee
Copy link

@zchee zchee commented May 22, 2023

gcpkms: fix WithCredentialsJSON to credentials.

The key.credentialJSO is already parsed, and this line condition is if credentials != nil {, so use the credentials variable.

@zchee
gcpkms: fix WithCredentialsJSON to credentials
19bee0c 
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
@zchee
Copy link
Author

zchee commented May 22, 2023

cc: @ajvb @joshkaplinsky

@ryanhos
Copy link

ryanhos commented Jun 2, 2023

The fix for this is contained in the patch for #1151. If we merge #1155, this PR goes away.

@hiddeco
Copy link
Member

hiddeco commented Jul 3, 2023

Closing this in favor of #1155. Thank you 🙇

@hiddeco hiddeco closed this Jul 3, 2023
@zchee zchee deleted the gcpkms-credentials branch July 6, 2023 01:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zchee @ryanhos @hiddeco