Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add In-app updates to Android #92

Closed
Tracked by #69
behzodhalil opened this issue Oct 6, 2023 · 11 comments
Closed
Tracked by #69

Add In-app updates to Android #92

behzodhalil opened this issue Oct 6, 2023 · 11 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest For contributors

Comments

@behzodhalil
Copy link
Member

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Additional context
Add any other context or screenshots about the feature request here.

@behzodhalil behzodhalil added enhancement New feature or request good first issue Good for newcomers hacktoberfest For contributors labels Oct 6, 2023
@behzodhalil
Copy link
Member Author

FYI: iOS does not have the auto update feature that Android has

@alibardide5124
Copy link
Contributor

Is this require google play panel, or I just need to code the app? If it doesn't need google play, I'd like to take it :)

@behzodhalil
Copy link
Member Author

Hey, @alibardide5124 ! Thanks for your interest our project!

Just need to add logic (in app updates) to our app.

@alibardide5124
Copy link
Contributor

Thanks, @behzodhalil. I'm on it.

Since I didn't work on multiplatform projects, this would be a good example to look at :)

@alibardide5124
Copy link
Contributor

By the way, I didn't see any release or download link. Where can I download APK file?

@behzodhalil
Copy link
Member Author

behzodhalil commented Oct 6, 2023

@alibardide5124

You can start by adding logic to the androidApp module, as it is specific to the android app. Now, the project is in the development stage and for this reason I haven't uploaded it yet, but you can run it locally.

Best regards :)

@alibardide5124
Copy link
Contributor

Hi. I've implemented update logic to app. It checks for update and finish app if user don't update. This was a project that requires security, so I assumed the user should immediately update for safety.

However, there was a catch... You see I didn't work with multimodule Gradle dependency in apps (Like your app that has navigation, AdMob, etc. folders in root directory) And I got an error as I opened project:

A problem occurred configuring project ':resource'.

Could not determine the dependencies of null.
Could not resolve all dependencies for configuration ':resource:classpath'.
> Failed to calculate the value of task ':build-logic:convention:compileJava' property 'javaCompiler'.
> No matching toolchains found for requested specification: {languageVersion=11, vendor=any, implementation=vendor-specific}.
> No locally installed toolchains match (see https://docs.gradle.org/8.0/userguide/toolchains.html#sec:auto_detection) and toolchain download repositories have not been configured (see https://docs.gradle.org/8.0/userguide/toolchains.html#sub:download_repositories).

It's related to your resource module. I spent a few hours, but I couldn't figure it out. So I just implemented logic in MainActivity.kt and push it. I pretty sure it works. Just test it from play console.

And greatly sorry for this :(

@behzodhalil
Copy link
Member Author

@alibardide5124 I'm pleased to see that you've implemented the "in-app update" feature. I've reviewed to your code.

Additionally, we are following the git flow branching strategy. For running CI/CD, please make a request to merge into the develop branch.

Thanks!

@behzodhalil
Copy link
Member Author

@alibardide5124
FYI: Now, I'm working with this issue #94. After finishing, gradle files will change.

@alibardide5124
Copy link
Contributor

Hi @behzodhalil. I just made some changes to code, and you can see diff here:
main...alibardide5124:anypass-kmp:fix_issue_#92_in_app_update

If you could, please check it out and tell me if I missed anything. I realized that I can't work on a multiplatform project with a Windows device, so I wrote logic in another project and implemented it on this project.

You mentioned earlier that I missed an important part of the in-app update. I checked my code and I didn't see what's wrong. Can you please tell me what I missed?

@behzodhalil
Copy link
Member Author

Hey, @alibardide5124!

Sorry for late response! I'll review right now your PR.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest For contributors
Projects
None yet
Development

No branches or pull requests

2 participants