Add pyyaml for management of docker-compose yaml files #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukechilds
force-pushed
the
master
branch
2 times, most recently
from
81f82e7 to
2694b7f
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the python3-yaml package as a dependency in UmbrelOS. The addition of this package is necessary to manage Docker-Compose YAML files effectively within UmbrelOS.
Changes
Added python3-yaml to the list of essential system utilities installed during the OS build process.
Removed duplicate installs of python3.
Reasoning
The python3-yaml package is required for parsing and managing YAML files, which are commonly used for Docker-Compose configurations. By including this package, we ensure UmbrelOS can handle Docker-Compose YAML files out of the box, improving the overall functionality and app developer experience.
Testing
❌ Built UmbrelOS with the updated Dockerfile.
❌ Verified that python3-yaml is installed and functional.
✅ Tested Docker-Compose YAML file management to ensure compatibility and functionality.
Notes
No breaking changes are introduced with this PR. The addition of python3-yaml is backward-compatible and should not affect existing functionality.