-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Catch classification exceptions #283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 52deb74 in 1 minute and 27 seconds
More details
- Looked at
41
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. graphiti_core/utils/maintenance/node_operations.py:161
- Draft comment:
The try/finally block here does not catch exceptions as intended. Use try/except to catch errors and log them in the except block instead of finally, which always executes. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_XXHjBs2tshAKyTS8
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Incremental review on 989ac7c in 1 minute and 20 seconds
More details
- Looked at
15
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. graphiti_core/utils/maintenance/node_operations.py:170
- Draft comment:
Good change catching exceptions in node classification. Consider using logger.exception (or logger.error with exc_info=True) to log the full traceback for easier debugging. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_2WMMI8myDRLD0fM2
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Important
Add exception handling for node classification errors in
extract_nodes
and update version to0.7.6
.extract_nodes
innode_operations.py
to catch and log errors during node classification.pyproject.toml
from0.7.5
to0.7.6
.This description was created by
for 989ac7c. It will automatically update as commits are pushed.