Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update image to v0.24 #1751

Closed
wants to merge 1 commit into from
Closed

Conversation

antonok-edm
Copy link
Contributor

As I discovered in jaredforth/webp#7 (comment), version v0.23 of the image crate did not support decoding lossless webp images. That caused panics when building a site which called resize_image on any lossless webp image.

As of image v0.24, decoding lossless webp images is now supported.

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

(Delete or ignore this section for documentation changes)

  • Are you doing the PR on the next branch?

If the change is a new feature or adding to/changing an existing one:

  • Have you created/updated the relevant documentation page(s)?
  • N/A, the lack of support for lossless webp images is not already mentioned in the docs anywhere

@Keats
Copy link
Collaborator

Keats commented Feb 1, 2022

Thanks for the PR!
Sorry I had a branch that changed all the 3rd party deps that I forgot to merge in next. I've done so now and I've updated image in that.

@Keats Keats closed this Feb 1, 2022
@antonok-edm antonok-edm deleted the image-v0.24 branch February 1, 2022 23:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants