Skip to content

gfx-rs with latest rust master is broken because FromStr was moved to core::str #439

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
subhashb opened this issue Nov 17, 2014 · 6 comments · Fixed by #440
Closed

gfx-rs with latest rust master is broken because FromStr was moved to core::str #439

subhashb opened this issue Nov 17, 2014 · 6 comments · Fixed by #440

Comments

@subhashb
Copy link

FromStr was moved into core::str recently: rust-lang/rust#18976
@brendanzab
Copy link
Contributor

Thanks for informing us!

@milibopp
Copy link
Contributor

There are also some problems with the macros… I'll see if I can fix it.

@brendanzab
Copy link
Contributor

Sorry - I can't test it right now because the mac nightlies are behind (see rust-lang/rust#19030)

@milibopp
Copy link
Contributor

The accompanying AST issue is due rust-lang/rust#18752. I think I fixed it but huonw/compile_msg#7 must be merged first, i.e. library compiles, test suite does not.

milibopp added a commit to milibopp/gfx-rs that referenced this issue Nov 17, 2014
@milibopp
Update to latest rust nightly
3209466 
The exact version is rustc 0.13.0-dev (0b7b4f075 2014-11-16 22:36:50 +0000) and
the relevant upstream issues are rust-lang/rust#18752 and rust-lang/rust#18976.

Fixes gfx-rs#439.
milibopp added a commit to milibopp/gfx-rs that referenced this issue Nov 17, 2014
@milibopp
Update to latest rust nightly
000c930 
The exact version is rustc 0.13.0-dev (0b7b4f075 2014-11-16 22:36:50 +0000) and
the relevant upstream issues are rust-lang/rust#18752 and rust-lang/rust#18976.

Fixes gfx-rs#439.
@milibopp milibopp mentioned this issue Nov 17, 2014
Merged
@subhashb
Copy link
Author

Aaah.. @aepsil0n got to it first 😄
I had done the same changes, but got stuck with issues in compile_msg.

@brendanzab
Copy link
Contributor

@subhashb no worries, thanks for your efforts!

adamnemecek pushed a commit to adamnemecek/gfx that referenced this issue Apr 1, 2021
@bors @kvark
Merge gfx-rs#439
3a11fab 
439: Refactor usage tracking to be truly sparse r=dependency a=kvark

~~This is a required step towards gfx-rs#438 . We want to be tracking the usage by only having resource IDs around, not resources themselves. So we aren't going to have access to `full_selector`.~~

It's also streamlining some of the verbose parts of the internal API for usage tracking.
It also uses `SmallVec` for the texture tracker ranges, essentially making it lightweight for most cases (where the layer count is 1).

Compromises:
  - removes `SEPARATE_DEPTH_STENCIL_STATES` support. It's not in the near future to enable it anyway.

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to latest rust nightly milibopp/gfx-rs
3 participants
@subhashb @brendanzab @milibopp