This repository has been archived by the owner on Jun 18, 2021. It is now read-only.
First Phase of Tracing Transition #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
force-pushed
the
tracing
branch
5 times, most recently
from
1ca2d04 to
1d63e36
Compare
bors bot
added a commit
to gfx-rs/wgpu
that referenced
this pull request
Jun 22, 2020
740: First Phase of Tracing Transition r=kvark a=cwfitzgerald ## Connections First step in the implementation of #491. gfx-rs/wgpu-rs#395 ## Description This adds the tracing crate, implements a tracing "layer" for chrome tracing, and instruments every entrypoint into wgpu. Tracing is added as a main dependency. A feature is added called `subscriber` which guards the tracing and default logger implementation, as that adds 3 dependencies. The main macro is there to make creating a span a simple one line process. This macro will come in useful in the next couple stages. Use of this macro is used unqualified with it imported into scope as that style allows IntelliJ ides to actually find the macro. I also removed a really annoying warning that was driving me crazy. This PR does not make sure the logging output from tracing is up to snuff, that will be done when logging output and conversion is the priority. Both commits should compile individually, so shouldn't need to be squashed. ## Testing This PR was tested with the wgpu-rs PR on various examples, as well as my personal project. Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
cwfitzgerald
force-pushed
the
tracing
branch
2 times, most recently
from
5270e25 to
6608914
Compare
|
Should be ready to review! |
kvark
suggested changes
Jun 22, 2020
examples/hello-triangle/main.rs
Outdated
| #[cfg(feature = "subscriber")] | ||
| { | ||
| let chrome_tracing_dir = std::env::var("WGPU_CHROME_TRACING"); | ||
| wgpu::util::initialize_default_subscriber(chrome_tracing_dir.ok()); |
There was a problem hiding this comment.
I don't think we need to show it off in hello- examples. Just framework is OK and most useful anyway.
There was a problem hiding this comment.
The reason I added this here too is because once we switch to tracing entirely, env_logger won't do anything, and I would imagine we want logging enabled. I can remove this for now and we can revisit it later if you want.
kvark
approved these changes
Jun 23, 2020
|
Wooooo! |
kejor
pushed a commit
to kejor/wgpu-rs
that referenced
this pull request
Nov 28, 2020
fix gfx-rs#395 Add BufferMapState enum to track the state of buffer mapping and store any mapping details in case one is pending.
kejor
pushed a commit
to kejor/wgpu-rs
that referenced
this pull request
Nov 28, 2020
547: Add BufferMapState r=kvark a=kunalmohan WIP for issue gfx-rs#395 Co-authored-by: Kunal Mohan <kunalmohan99@gmail.com>
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
This is the wgpu-rs component of gfx-rs/wgpu#740.
Notable Changes