Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add pipeline constants plumbing #4730

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Nov 20, 2023

Adds pipeline constants plumbing to the pipeline-constants feature branch.

Tracking meta issue: #4484.

Take 3 (#4677, #4683).

@teoxoy teoxoy requested review from a team November 20, 2023 15:03
@teoxoy teoxoy requested a review from a team as a code owner November 20, 2023 15:03
@teoxoy teoxoy force-pushed the pipeline-constants branch from 44e86e7 to a05e269 Compare November 20, 2023 15:08
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bringing in my approval from #4683.

@ErichDonGubler
Copy link
Member

FTR: @crowlKats has previously approved this at #4683 (review).

@cwfitzgerald
Copy link
Member

Tests in a future MR pretty please 👉🏻👈🏻

Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some minor suggestions.

@teoxoy teoxoy force-pushed the pipeline-constants branch from a05e269 to f46258e Compare November 21, 2023 18:34
@teoxoy teoxoy merged commit ef82a82 into gfx-rs:pipeline-constants Nov 21, 2023
@teoxoy teoxoy mentioned this pull request Apr 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants