Potentially optimize dot4{I,U}8Packed on Metal
#7653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might allow the Metal compiler to emit faster code (but that's not confirmed). See <gpuweb/gpuweb#2677 (comment)> for the optimization. The limitation to Metal 2.1+ is discussed here: <gfx-rs#7574 (comment)>.
robamler
force-pushed
the
packed-vector-format-metal
branch
from
a6825c8 to
8813b38
Compare
This comment was marked as resolved.
This comment was marked as resolved.
CI on test failed because the latest changes to `put_block` made its stack too big. Factoring out the new code into a separate method fixes this issue.
robamler
force-pushed
the
packed-vector-format-metal
branch
from
be668ce to
2a41b95
Compare
|
I fixed the issue of an excessive stack size of The previously failing CI test can be run on a non-mac machine as follows: cd naga
cargo test --features msl-out test_stack_size |
9 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
dot4{I, U}8Packedon SPIR-V and HLSL #7574 (comment)Description
On Metal >= 2.1, emit code for
dot4I8Packedanddot4U8Packedthat might be easier to optimize for the compiler.Testing
Squash or Rebase?
Needs squashing.
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.