Skip to content

Add a param to force the [end of text] to show, even in interactive mode #967

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
jeffersoncgo opened this issue Apr 14, 2023 · 2 comments
Closed
Labels

Comments

@jeffersoncgo
Copy link

jeffersoncgo commented Apr 14, 2023

Is possible to add a param to allow force show the [end of text] token?

like this(i think, don't understand C/C++)

if (!embd.empty() && embd.back() == llama_token_eos()) {
    if (params.forceendtoken || !params.instruct) {
        fprintf(stderr, " [end of text]\n");
    }
    if (params.instruct) {
        is_interacting = true;
    } else {
       break;
    }
}
@jeffersoncgo
Copy link
Author

jeffersoncgo commented Apr 14, 2023

Update, looking at the code, i tryed to compile it here, but is really slow, compared to the released.
Lines i sujest(beg) to change(or make better, i didn't take performance into consideration)

main.cpp

if (!embd.empty() && embd.back() == llama_token_eos()) {
            if (instruct_mode) {
                is_interacting = true;
            } else {
                fprintf(stderr, " [end of text]\n");
                break;
            }
        }

to

if (!embd.empty() && embd.back() == llama_token_eos()) {
            if (params.forceendtoken || !params.instruct) {
                fprintf(stderr, " [end of text]\n");
            }
            if (params.instruct) {
                is_interacting = true;
            }
            else {
                break;
            }
        }

and

commom.cpp

} else {
             fprintf(stderr, "error: unknown argument: %s\n", arg.c_str());
            gpt_print_usage(argv[0], default_params);
            exit(1);
}

to

} else if (arg == "--forceendtoken") {
            params.forceendtoken = true;
} else {
            fprintf(stderr, "error: unknown argument: %s\n", arg.c_str());
            gpt_print_usage(argv[0], default_params);
            exit(1);
}

commom.h - on "struct gpt_params"

bool multiline_mode    = true; // enables multi-line mode, to send input press CTRL+D on Linux/Max, Ctrl+Z then Return on Windows

bellow it add

bool forceendtoken     = true; // Force show the "[end of text]" token after the generation

I did it and "worked" but the generation became really slow.

If possible, please, add these

Deadsg pushed a commit to Deadsg/llama.cpp that referenced this issue Dec 19, 2023
multi modal params fix: add logits = True -> to make llava work
@github-actions github-actions bot added the stale label Mar 25, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

This issue was closed because it has been inactive for 14 days since being marked as stale.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant