ggml_used_mem can segfault if called before any objects are created. #1264

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Merged

ggerganov merged 1 commit into ggml-org:master from KerfuffleV2:fix-used_mem_segfault

May 1, 2023

Collaborator

KerfuffleV2 commented May 1, 2023 •

edited

Loading

ggml_used_mem currently blindly dereferences ctx->objects_end, however that pointer is initially NULL and is only set when objects are created.

This tiny change just has it return 0 in that case (presumably if no objects were ever created, no memory is used).


          ggml_used_mem can segfault if called before any objects are created.

acae41c

slaren approved these changes

View reviewed changes

ggerganov merged commit 2bdc096 into ggml-org:master

KerfuffleV2 deleted the fix-used_mem_segfault branch

May 28, 2023 08:45

Bearsaerker mentioned this pull request

Eval bug: Gemma 3 extremly slow prompt processing when using quantized kv cache. #12352

Open

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet