ggml : add ggml_scale_bias #14417
Draft
ggml : add ggml_scale_bias #14417
+59
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hope this won't have a significant impact on the performance |
github-actions
bot
added
testing
ggerganov
reviewed
Jun 27, 2025
Comment on lines
+3968
to
+3971
| ggml_vec_scale_f32(nc, (float *) ((char *) dst->data + i1*nb1), s); | ||
| if (b != 0.0f) { | ||
| ggml_vec_acc1_f32(nc, (float *) ((char *) dst->data + i1*nb1), b); | ||
| } |
There was a problem hiding this comment.
Merge these in ggml_vec_mad1_f32(). If you want, you can try to add a GGML_SIMD version using GGML_F32_VEC_FMA - it's quite simple. But also can leave it a basic for loop without SIMD.
|
Quick question: Is the "scale-bias" nomenclature more appropriate here than "multiply-add"? From an outsider perspective familiar with fused multiply-add ("MAD") operations, I didn't realize that "scale" meant "multiply" and "bias" meant "add" until I took a closer look. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref discussion: #14400 (comment)
Added
ggml_scale_bias(ctx, a, s, b)in this PR, which allows calculatingx = a * s + bI only added Metal kernel for now, just for discussion. @ggerganov does this looks good to you?
TODO: support other backends