Skip to content

benchmark-matmul: fix clang-tidy issues, report results in GFLOPS #1458

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2023
Merged

benchmark-matmul: fix clang-tidy issues, report results in GFLOPS #1458

merged 2 commits into from
May 14, 2023

Conversation

slaren
Copy link
Member

@slaren slaren commented May 14, 2023

Very minor change to fix a bug detected by clang-tidy in command line parsing, and some minor cleanup.

  • Fixed command line parsing
  • Replaced macros with functions
  • Results are reported in GFLOPS instead of FLOPS_per_u_Second

@slaren slaren merged commit b5c9295 into ggml-org:master May 14, 2023
@slaren slaren deleted the benchmm-fix branch May 14, 2023 20:46
@Bearsaerker Bearsaerker mentioned this pull request Mar 12, 2025
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slaren @ggerganov