Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Chat UI extras #2366

Merged
merged 5 commits into from
Jul 24, 2023
Merged

Chat UI extras #2366

merged 5 commits into from
Jul 24, 2023

Conversation

akx
Copy link
Contributor

@akx akx commented Jul 24, 2023

This PR tweaks the server example's UI a bit and exposes the generation parameters that weren't previously available in a neat <details> disclosure box.

Screenshot

Screenshot 2023-07-24 at 12 12 19

@SlyEcho
Copy link
Collaborator

SlyEcho commented Jul 24, 2023

I added them all in #2217, I'll try to wrap it up soon, the design is messy right now.

I'm not sure if a separate integer field is needed, in I use just Float. Mirostat setting would be better to display as checkboxes.

Not sure if there is anything that is "advanced" or "basic" because these are all available in main.cpp etc.

@akx
Copy link
Contributor Author

akx commented Jul 24, 2023

I added them all in #2217, I'll try to wrap it up soon, the design is messy right now.

So does this have a chance to be merged at all? 😅

I'm not sure if a separate integer field is needed, in I use just Float.

It felt cleaner to add that now.

Mirostat setting would be better to display as checkboxes.

Sure, I can do that. Radio buttons, I presume :)

Not sure if there is anything that is "advanced" or "basic" because these are all available in main.cpp etc.

I was trying to keep the layout a little less bewildering by hiding at least some things in the disclosure by default.

@SlyEcho
Copy link
Collaborator

SlyEcho commented Jul 24, 2023

It can still be useful to merge, especially the design elements.

Let me test it out.

@akx
Copy link
Contributor Author

akx commented Jul 24, 2023

Made the Mirostat fields a radio group:
Screenshot 2023-07-24 at 13 15 23

@SlyEcho
Copy link
Collaborator

SlyEcho commented Jul 24, 2023

I currently have it like this, no Mirostat means Temperature Sampling:
image


Mirostat v1 or v2 uses different parameters:
image


Disabling repeat_last_n also disables the token penalties:
image


Disabling Temperature gets rid of all sampling options:
image

@SlyEcho SlyEcho merged commit b3f138d into ggml-org:master Jul 24, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants