Add initial AVX512 support for dot product on Linux #320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I am seeing different outputs when running with these changes. They seem of equal quality, but this isn't something I observed when first testing this out on alpaca.cpp.
It's possible that some rounding behavior is happening slightly differently or something like that. If this is a dealbreaker, I can try to figure out what is causing the difference and check if it's possible to get rid of it.
Changes
Performance Impact
I initially implemented this over on alpaca.cpp where I saw an ~10% speedup to inferrence.
Before:
After:
I was hoping for more, but some other stuff I tried like converting the
bytesFromNibbles
function to operate on two blocks at a time by using AVX512 were not successful.