Skip to content

Port to Visual C++. #36

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

jaykrell
Copy link

@jaykrell jaykrell commented Mar 12, 2023

  • Combined nmake/Unix Makefile.
  • _alloca instead of variable size array.
  • Do not do math on void*, could cast to char*, but in this case, move the uint8_t* cast.
  • C++20 for designated initializers.
  • Conditionalize on _WIN32, not specific compilers.

It builds. I haven't run it yet.

- Combined nmake/Unix Makefile.
- _alloca instead of variable size array.
- Cast void* to char* for math.
- C++20 for designated initializers.

It builds. I haven't run it yet.
@ggerganov ggerganov mentioned this pull request Mar 12, 2023
@ggerganov
Copy link
Member

We will merge #31 first and then see how to update the build system - either CMake or what you suggested here

@ggerganov
Copy link
Member

We already merged CMake support which provide Windows build

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants