Skip to content

Revert "Delete SHA256SUMS for now" #429

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Mar 23, 2023
Merged

Conversation

sw
Copy link
Contributor

@sw sw commented Mar 23, 2023

Reverts #416

@prusnak
Copy link
Collaborator

prusnak commented Mar 23, 2023

Let's drop lines with ggml-model-*.bin from the file, since these are generated and not downloaded.

@sw
Copy link
Contributor Author

sw commented Mar 23, 2023

Let's drop lines with ggml-model-*.bin from the file, since these are generated and not downloaded.

Assuming the generation is deterministic, we'll still eventually want to have them in here, right?

@prusnak
Copy link
Collaborator

prusnak commented Mar 23, 2023

Assuming the generation is deterministic, we'll still eventually want to have them in here, right?

I think so. Once the file format stop changing every couple of days :-)

@sw sw marked this pull request as ready for review March 23, 2023 14:01
@Green-Sky
Copy link
Collaborator

or filenames reflect the full version :)

@sw sw requested a review from Green-Sky March 23, 2023 14:10
@prusnak
Copy link
Collaborator

prusnak commented Mar 23, 2023

I added one commit to reflect changes in the readme and also added models/tokenizer.model to SHA256SUMS

Copy link
Collaborator

@Green-Sky Green-Sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not check the hashes, but looks good

@sw sw merged commit a50e39c into master Mar 23, 2023
@j-f1 j-f1 deleted the revert-416-patch-delete-sha256sums branch March 23, 2023 14:16
Deadsg pushed a commit to Deadsg/llama.cpp that referenced this pull request Dec 19, 2023
…terial-9.1.17

Bump mkdocs-material from 9.1.16 to 9.1.17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants