Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

with logits_all == true, use to the last logits vector #498

Closed
wants to merge 1 commit into from
Closed

with logits_all == true, use to the last logits vector #498

wants to merge 1 commit into from

Conversation

Piezoid
Copy link
Contributor

@Piezoid Piezoid commented Mar 25, 2023

Affects llama_sample_top_p_top_k and params.ignore_eos mode in main.cpp.
Alternatively the sampler could take an additional argument indicating the position to sample in the batch.
As of now, I haven't come across any code path that hit this issue (beside my changes in #477).

@Piezoid
Copy link
Contributor Author

Piezoid commented Mar 25, 2023

Resolved in 03f7e33.

@Piezoid Piezoid closed this Mar 25, 2023
@Piezoid Piezoid deleted the seeklogits branch March 25, 2023 19:14
Deadsg pushed a commit to Deadsg/llama.cpp that referenced this pull request Dec 19, 2023
Added info to set ENV variables in PowerShell
AAbushady pushed a commit to AAbushady/llama.cpp that referenced this pull request Jan 27, 2024
* Update colab.ipynb

* Update colab.ipynb

* Update colab.ipynb

* Update colab.ipynb

* Update colab.ipynb

* Update colab.ipynb

* Update colab.ipynb

* Update colab.ipynb

* Update colab.ipynb

* Update colab.ipynb

* Update colab.ipynb

* Update colab.ipynb

* Update colab.ipynb

* Update colab.ipynb

* Update colab.ipynb

* Update colab.ipynb

* Update colab.ipynb
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant