Skip to content

Misc: Use argparse #72

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

Dietr1ch
Copy link

My take at #70.

I tried using black for formatting, but things are not in a great shape now, so I just tried to match the format on the lines I had to change.

This looks correct to me, but I haven't been able to run the converted model yet, so I can't verify. I was able to convert it just fine, but got some tensor dimension mismatch later.

Co-authored-by: Jed Fox <git@jedfox.com>
@ggerganov
Copy link
Member

Hi, thanks for contributing!
There is no need to add extra dependencies for such simple things, such as argument parsing.
The current way is good enough. It can be improved by adding comments and better help description, etc.

@ggerganov ggerganov closed this Mar 13, 2023
@leszekhanusz
Copy link

argparse is part of the Python standard library, so this PR does not add any new dependency.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants