Include examples/common.cpp in CMakeLists.txt #783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
requested changes
Apr 5, 2023
| llama.h) | ||
| llama.h | ||
| examples/common.cpp | ||
| examples/common.h) | ||
|
|
There was a problem hiding this comment.
llama should not build examples/common.cpp
It is part of the common library which is used only by the examples.
Your project should re-implement the stuff in common
There was a problem hiding this comment.
I'll think of another way
Deadsg
pushed a commit
to Deadsg/llama.cpp
that referenced
this pull request
Dec 19, 2023
Co-authored-by: john.shen <john.shen@bioclinica.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when building 3rdparty applications.
See https://github.com/iacore/llama-tui
This is a bodge. There are better ways to do this, probably.