-
Notifications
You must be signed in to change notification settings - Fork 11.4k
do not force the prompt file to end with a new line #908
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
bde6046
to
bc6a5ce
Compare
The changes to |
Agree with @slaren — the space should be removed.
Okay, so the space should be removed. What about newline at the end of prompt files? Should it be kept or removed too? |
It depends on the prompt but in these cases it should be removed, adding a new line at the end of a prompt should be a deliberate choice and not something forced by the editor. |
I am asking about the two particular prompt files I touched in this PR. |
I don't think these prompts should end in a new line. |
bc6a5ce
to
9b52fc3
Compare
No description provided.