fix-schema-generation-for-list-dict-fields #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…include examples that fail the schema validation done by schemathesis
…t fields. For example, the regex `\d+\.field1` is used in the API schema to indicate that the API will return attribute values like `0.field1`, `1.field1`. Previously, attr was incorrectly specified as an enum with the value `INDEX.field1` that represents the actual API output. fix #76
DICT_KEY_IN_API_SCHEMA settings
…rializers and list/dict fields
…/dict fields in the generated API schema
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a pattern to correctly describe the
attrvalue in validation errors in all cases.Specifically, this fixes the incorrect description of the
attrvalue for list serializers and list/dict fields.Taking the example of a list serializer with 1 field named
my_field. The validation errors for this field will have theattrvalue set as0.my_field,1.my_field, ...attrvalue was described with an enum having a single valueINDEX.my_field.\d+\.my_fieldand this pattern correctly described the actualattrvalue returned by the API0.my_field,1.my_field, ...