Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added support for ol@5.3.3 #3

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Conversation

rpFilipe
Copy link
Contributor

@rpFilipe rpFilipe commented Jul 8, 2019

Hi @ghettovoice , I saw that you opened an issue #2 for adding support for ol v5 but never got around to implement it. I've made the alterations, tested and everything seems to be working.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.667%

Totals Coverage Status
Change from base Build 8: 0.0%
Covered Lines: 43
Relevant Lines: 57

💛 - Coveralls

@ghettovoice
Copy link
Owner

Great!
I totally forget about this issue 🤦‍♂️
Thank you.

@ghettovoice ghettovoice merged commit 2475fba into ghettovoice:master Jul 9, 2019
@ghettovoice ghettovoice self-requested a review July 9, 2019 07:26
@rpFilipe
Copy link
Contributor Author

rpFilipe commented Jul 9, 2019

Do you have a ETA to when you are going to release the new version?

ghettovoice added a commit that referenced this pull request Jul 9, 2019

Verified

This commit was signed with the committer’s verified signature.
ghettovoice Vladimir Vershinin
Upgraded to support ol >= v5 (#3 thanks to @rpFilipe)
@ghettovoice
Copy link
Owner

Already released

@rpFilipe
Copy link
Contributor Author

rpFilipe commented Jul 9, 2019

Thanks :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants