Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

python bindings for structured grids: improved make_communication_object function #162

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

boeschf
Copy link
Collaborator

@boeschf boeschf commented Apr 4, 2024

The communication object is wrapped in a type-erased shim class (structured case). Therefore, the make_communication_object function doesn't need the superfluous second argument anymore (this argument was only needed to inject the type and was confusing to use).
Type injection happens at exchange time now, and subsequently, the communication_object template instance is retrieved from a std::variant.

@boeschf boeschf merged commit 5b83a92 into ghex-org:master Apr 4, 2024
9 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant