Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

set arch = None default im make_field_descriptor #166

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

halungge
Copy link
Contributor

@halungge halungge commented Nov 6, 2024

Setting arch = None as default in make_field_descriptor:

With the default=Architecture.CPU the caller needs to explicity call make_field_descriptor with None in order to take advantage of GHEX determining the architecture base on the field.__x__array_interface__ attribute. This is easy to miss.

@boeschf boeschf merged commit 38cc693 into ghex-org:master Dec 16, 2024
6 of 9 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants