Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adding timeout to the http client #54

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Adding timeout to the http client #54

merged 4 commits into from
Aug 9, 2024

Conversation

dontseyit
Copy link
Member

@dontseyit dontseyit commented Aug 9, 2024 •
edited
Loading

This PR adds a timeout of 60 seconds to the HTTP client being used. The issue arose when we encountered problems uploading files to the S3 server.

Template files and outdated dependencies are also updated.

@dontseyit dontseyit requested a review from Cito August 9, 2024 09:32
@dontseyit dontseyit merged commit f3532cf into main Aug 9, 2024
6 checks passed
@dontseyit dontseyit deleted the feature/add-timeout-to-client branch August 9, 2024 09:35
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10316824941

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 75.678%
Totals Coverage Status
Change from base Build 10269873046: 0.03%
Covered Lines: 725
Relevant Lines: 958
💛 - Coveralls

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Cito Cito Cito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dontseyit @coveralls @Cito