Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Request timeout/retries now user configurable #56

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

mephenor
Copy link
Member

@mephenor mephenor commented Aug 20, 2024

Upload errors now include underlying error directly in message string to reduce crawling through the stack trace.
Non 200 part upload responses now raise an exception after internal httpx retries.

Also bumped minor version.

@mephenor mephenor requested a review from dontseyit August 20, 2024 08:08
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10467783282

Details

  • 22 of 31 (70.97%) changed or added relevant lines in 5 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 75.773%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ghga_datasteward_kit/s3_upload/uploader.py 3 5 60.0%
src/ghga_datasteward_kit/s3_upload/utils.py 12 19 63.16%
Files with Coverage Reduction New Missed Lines %
src/ghga_datasteward_kit/s3_upload/uploader.py 1 90.16%
src/ghga_datasteward_kit/s3_upload/utils.py 5 70.2%
Totals Coverage Status
Change from base Build 10318624985: 0.1%
Covered Lines: 735
Relevant Lines: 970

💛 - Coveralls

Copy link
Member

@dontseyit dontseyit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me

@mephenor mephenor merged commit 30f87a7 into main Aug 20, 2024
6 checks passed
@mephenor mephenor deleted the fix/timeout_config branch August 20, 2024 08:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants