Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Unlimited timeout #58

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Unlimited timeout #58

merged 2 commits into from
Aug 21, 2024

Conversation

mephenor
Copy link
Member

This should allow setting the request timeout to "None" resulting in not timeout for the client requests.

@mephenor mephenor requested a review from dontseyit August 21, 2024 13:11
dontseyit
dontseyit approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@dontseyit dontseyit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me, thank you.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10491579685

Details

  • 4 of 5 (80.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.773%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ghga_datasteward_kit/s3_upload/uploader.py 0 1 0.0%
Totals Coverage Status
Change from base Build 10472366441: 0.0%
Covered Lines: 741
Relevant Lines: 991
💛 - Coveralls

@mephenor mephenor merged commit b319946 into main Aug 21, 2024
6 checks passed
@mephenor mephenor deleted the feature/infinite_timeout branch August 21, 2024 14:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dontseyit dontseyit dontseyit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mephenor @coveralls @dontseyit