Fetch dvm git data with --all option #69
Open
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ghosind <ghosind@gmail.com>
dvm.sh
Outdated
| git checkout "$DVM_LATEST_VERSION" | ||
|
|
||
| dvm_print "DVM has upgrade to latest version, please restart your terminal or run \`source $DVM_PROFILE_FILE\` to apply changes." | ||
| if git reset --hard HEAD && git fetch --all && git pull origin master --tag && git checkout "$DVM_LATEST_VERSION" |
There was a problem hiding this comment.
Not sure the fetch --all is necessary
There was a problem hiding this comment.
fetch --all should be enough for this problem, and I keep pull --tags to double check
There was a problem hiding this comment.
The branch to fetch is not in a global variable?
There was a problem hiding this comment.
No, it is in the global variable DVM_LATEST_VERSION
Signed-off-by: Chen Su <ghosind@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch DVM Git data with the
--alloption to ensure that tags are pulled.Fix #68 .