Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Not working with macro tooltips #3

Closed
WanderingFox opened this issue Nov 25, 2022 · 4 comments
Closed

Not working with macro tooltips #3

WanderingFox opened this issue Nov 25, 2022 · 4 comments

Comments

@WanderingFox
Copy link

WanderingFox commented Nov 25, 2022

Firstly, thank you for this addon. It's incredibly handy :)

Unfortunately the fix from @Zaazu doesn't seem to work with macro tooltips, even if you add a handler for macros. Looks like GetSpell doesn't return anything for macro tooltips :(

Posting mostly for visibility since I can't see a way to implement it for macros currently without scanning the tooltip text.

@Zaazu
Copy link
Collaborator

Zaazu commented Nov 25, 2022

Hey, did it work before dragonflight? Can you paste the macro you're using and I'll take a look

@WanderingFox
Copy link
Author

WanderingFox commented Nov 25, 2022

Sure!

#showtooltip
/cast [mod] Return To Camp; Timewalker's Hearthstone

Pre-dragonflight if you hovered over that macro while holding a modifier key you'd get the Return To Camp tooltip with the caravana line added (presumably because both spells and macros used the same GameTooltip). Now, with the latest version of caravana nothing happens (because it only adds a hook to spell tooltips). If you refactor it to add the same handler for macro tooltips as well, nothing happens either because the _, SpellId = self:GetSpell() line returns nil.

Zaazu added a commit to Zaazu/Caravana that referenced this issue Nov 25, 2022
@Zaazu
Copy link
Collaborator

Zaazu commented Nov 25, 2022

Couldn't figure out an elegant solution but atleast it should work for now. I ended up scanning the tooltip like you said, it's not pretty but for such a small addon, I don't think it'll cause problems.

gi2k15 added a commit that referenced this issue Nov 25, 2022
Fixed adding text to macro spell #3
@WanderingFox
Copy link
Author

TY for this :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants