Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added Climate entity. Fixed light state management. #27

Merged
merged 18 commits into from
Feb 12, 2023

Conversation

optiluca
Copy link
Contributor

  • added climate entity support. Only supports heating control.
  • fixed light entity state management, should now instantly update in ui, and not have to wait for the next state poll.

optiluca added 18 commits May 7, 2022 13:45
…htness state. Also assumes that all bulbs support brightness...
…mable and not, and found the right permutation of states to ensure that the brightness state is correctly handled.
… become clear that the implementation is intrinsically poor. We should be 1) fixing the position sensing upstream and 2) monitoring that.
…to just be position, but don't trust it yet...
…omehow removed this from lights in particular.
Copy link
Contributor Author

@optiluca optiluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the diff also includes commits that have already been merged. Might be related to this? https://stackoverflow.com/questions/16306012/github-pull-request-showing-commits-that-are-already-in-target-branch

@gicamm gicamm merged commit f39b295 into gicamm:master Feb 12, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants