-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Added Climate entity. Fixed light state management. #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
optiluca
commented
Feb 12, 2023
- added climate entity support. Only supports heating control.
- fixed light entity state management, should now instantly update in ui, and not have to wait for the next state poll.
…htness state. Also assumes that all bulbs support brightness...
…mable and not, and found the right permutation of states to ensure that the brightness state is correctly handled.
… become clear that the implementation is intrinsically poor. We should be 1) fixing the position sensing upstream and 2) monitoring that.
…r state correctly!
…to just be position, but don't trust it yet...
…omehow removed this from lights in particular.
optiluca
commented
Feb 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason the diff also includes commits that have already been merged. Might be related to this? https://stackoverflow.com/questions/16306012/github-pull-request-showing-commits-that-are-already-in-target-branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.