Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: Add support to custom t names on custom translation hooks #276

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

guiedugt
Copy link
Contributor

Using custom t names combined with custom translation hooks is not working as expected.
For example, the translation keys will not be extracted:

function MyComponent() {
  const { myTranslationFunction } = useMyTranslationHook('namespace');

  return <p>{myTranslationFunction('myTranslationKey')}</p>;
}

After some investigation, I found this is due to a hardcoded "t" key inside the useTranslationHook extractor:

const tBinding = id.scope.bindings['t'];

This PR adds some simple logic to try out different function names in the order they are defined in the tFunctionNames configuration parameter

@gilbsgilbs gilbsgilbs merged commit 1a4820d into gilbsgilbs:master Dec 7, 2024
5 checks passed
@gilbsgilbs
Copy link
Owner

Sorry for the delay, I completely missed this PR due to personal struggles. I wanted to emphasize that it is very well written and thank you for your contribution. I'll try to publish a release tomorrow after some maintenance chore. Probably a breaking release btw.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants