-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Workaround for renaming doesn't work on windows #8
Comments
I need to try this scenario with Windows, to check what can be done. If I install ounit 2.1.2 and I have the following dune file: dune: You think the test will fail to build? |
Yes, I've create #9 in order to see, if I can trigger the error with the CI. |
Windows failure: https://ci.appveyor.com/project/gildor478/ounit/builds/27635212#L653 |
Thanks a lot. I can now reproduce the problem. Maybe I can just use REVDEPS=re. I see 2 solutions for now:
|
The commit 53b9d1a should have solved the issue. I'll do a release soon, let me know if you think there is a problem. |
CHANGES: ### Changed - Rename ounit/ounit-lwt OPAM and library to ounit2/ounit2-lwt. The META file to rename oUnit to ounit was not working on Windows and MacOSX because their filesystems are case insensitive and the install directories were the same. The new ounit2/ounit2-lwt packages avoid name clash on Windows/MacOSX and we still have ounit/ounit-lwt to allow the transition to the new package name. (Closes: gildor478/ounit#8)
* [new release] ounit2-lwt, ounit2, ounit-lwt and ounit (2.2.0) CHANGES: ### Changed - Rename ounit/ounit-lwt OPAM and library to ounit2/ounit2-lwt. The META file to rename oUnit to ounit was not working on Windows and MacOSX because their filesystems are case insensitive and the install directories were the same. The new ounit2/ounit2-lwt packages avoid name clash on Windows/MacOSX and we still have ounit/ounit-lwt to allow the transition to the new package name. (Closes: gildor478/ounit#8) * Update packages/ounit2-lwt/ounit2-lwt.2.2.0/opam Co-Authored-By: Kate <kit.ty.kate@disroot.org> * Update opam * Update opam * Update packages/ounit-lwt/ounit-lwt.2.2.0/opam Co-Authored-By: Kate <kit.ty.kate@disroot.org> * Update packages/ounit/ounit.2.2.0/opam Co-Authored-By: Kate <kit.ty.kate@disroot.org>
* [new release] ounit2-lwt, ounit2, ounit-lwt and ounit (2.2.0) CHANGES: ### Changed - Rename ounit/ounit-lwt OPAM and library to ounit2/ounit2-lwt. The META file to rename oUnit to ounit was not working on Windows and MacOSX because their filesystems are case insensitive and the install directories were the same. The new ounit2/ounit2-lwt packages avoid name clash on Windows/MacOSX and we still have ounit/ounit-lwt to allow the transition to the new package name. (Closes: gildor478/ounit#8) * Update packages/ounit2-lwt/ounit2-lwt.2.2.0/opam Co-Authored-By: Kate <kit.ty.kate@disroot.org> * Update opam * Update opam * Update packages/ounit-lwt/ounit-lwt.2.2.0/opam Co-Authored-By: Kate <kit.ty.kate@disroot.org> * Update packages/ounit/ounit.2.2.0/opam Co-Authored-By: Kate <kit.ty.kate@disroot.org>
The workaround for renaming oUnit doesn't work on windows and probably with other filesystems that are case insensitive.
ounit/Makefile
Line 54 in d0e06a9
ounit/Makefile
Line 55 in d0e06a9
oUnit
is referenced instead of ounit inside a dune file,oUnit
can't be found (the name of the library seems to be determined by the dune-package file, not the directory name). ocamlfind doesn't seem to have this problem.The text was updated successfully, but these errors were encountered: