Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make install script compliant #1469

Merged

Conversation

Mycobee
Copy link
Contributor

@Mycobee Mycobee commented Nov 7, 2023

This lack of space breaks the script on some less featured shells. This commit fixes it

Copy link
Collaborator

@mjcheetham mjcheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you

Copy link
Contributor

@vdye vdye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @Mycobee! This looks good to me, but I've tagged @mjcheetham (GCM's maintainer) to make sure I'm not missing something.

@mjcheetham mjcheetham enabled auto-merge November 7, 2023 22:23
@mjcheetham mjcheetham merged commit df96311 into git-ecosystem:main Nov 7, 2023
@mjcheetham mjcheetham mentioned this pull request Apr 16, 2024
mjcheetham added a commit that referenced this pull request Apr 16, 2024
**Changes:**

- Fixes to install from source script (#1469)
- Use Avalonia generated view code (#14790
- Various GitHub Actions updates (#1473, #1483, #1487, #1486, #1488,
#1528, #1547)
- Fix bug in Azure Repos URL handling (#1522)
- Add Azure Managed Identity and SP docs (#1548)
- Fix error messages when using GCM outside of repo (#1561, #1583)
- Remove ESRP (#1571)
- Update to .NET 8 for Mac and Linux (#1579, #1580)
- Fix Alpine install from source script (#1582)
@Longest233

This comment has been minimized.

TNTurner23

This comment was marked as off-topic.

@R2kbappy

This comment was marked as spam.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants