Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added Visual Studio Code Insiders Support #180

Closed
wants to merge 13 commits into from
Closed

Added Visual Studio Code Insiders Support #180

wants to merge 13 commits into from

Conversation

justalemon
Copy link
Contributor

@justalemon justalemon commented Apr 19, 2018

This fixes git-for-windows/git#1513.

The result is quite good:
imagen

I installed the build with this settings:
imagen

And it was completed without problems:
imagen

As you can see in the first picture, I added a message about the differences between Code Stable (blue) and Insiders (green).

@dscho
Copy link
Member

dscho commented Apr 20, 2018

Thank you so much for this contribution! It is exciting to see support for the Insiders version of VS Code.

I would like to ask for three changes, though:

  • In general, I like to have every revision in a topic branch consistent. In particular, no commit should introduce a bug that is resolved in a subsequent commit in the same topic branch. For example, 4c0faba should be squashed into a19aa9e, should be squashed into 9987f21, and other commits really do not make sense on their own, such as replaying previous choices not from the start, but only from the middle of the topic branch. In fact, I could imagine that all these commits should be squashed into one, consistent commit that adds support for Visual Studio Code Insiders.

  • The commit messages should be self-contained. Ideally, the reader who stumbles across one commit should have all the information necessary to understand the "Why?" of the diff from the commit message. See e.g. 51961c6 which describes the purpose very well, and concisely. Something along these lines:

installer: offer to use VS Code - Insiders as Git's default editor

VS Code comes in the "Insiders" flavor, i.e. updated every night from the then-current `master`.
For users who like this bleeding edge, let's offer the Insiders flavor alongside the regular VS
Code version, separately autodetecting the presence of either.
  • could you please add your Sign-off to the commit message(s)? This will please the DCO bot and avoid marking the checks as failed.

@justalemon
Copy link
Contributor Author

@dscho I'm going to send a new quick PR.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installer doesn't detect VSCode Insiders.
2 participants