Skip to content

fetch-pack.c: enable fscache for stats under .git/objects #1426

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2018
Merged

fetch-pack.c: enable fscache for stats under .git/objects #1426

merged 1 commit into from
Jan 12, 2018

Conversation

atetubou
Copy link

When I do git fetch, git call file stats under .git/objects for each
refs. This takes time when there are many refs.

By enabling fscache, git takes file stats by directory traversing and that
improved the speed of fetch-pack for repository having large number of
refs.

In my windows workstation, this improves the time of git fetch for
chromium repository like below. I took stats 3 times.

  • With this patch
    TotalSeconds: 9.9825165
    TotalSeconds: 9.1862075
    TotalSeconds: 10.1956256
    Avg: 9.78811653333333

  • Without this patch
    TotalSeconds: 15.8406702
    TotalSeconds: 15.6248053
    TotalSeconds: 15.2085938
    Avg: 15.5580231

Signed-off-by: Takuto Ikuta tikuta@chromium.org

fetch-pack.c: enable fscache for stats under .git/objects
0323774 
When I do git fetch, git call file stats under .git/objects for each
refs. This takes time when there are many refs.

By enabling fscache, git takes file stats by directory traversing and that
improved the speed of fetch-pack for repository having large number of
refs.

In my windows workstation, this improves the time of `git fetch` for
chromium repository like below. I took stats 3 times.

* With this patch
TotalSeconds: 9.9825165
TotalSeconds: 9.1862075
TotalSeconds: 10.1956256
Avg: 9.78811653333333

* Without this patch
TotalSeconds: 15.8406702
TotalSeconds: 15.6248053
TotalSeconds: 15.2085938
Avg: 15.5580231

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
@atetubou
Copy link
Author

This is reland of #1372
But for faster stats of loose object files under .git/objects, not to cache stats under .git/objects/pack

@dscho dscho merged commit d0192a7 into git-for-windows:master Jan 12, 2018
@dscho
Copy link
Member

dscho commented Jan 12, 2018

Thanks, looks good!

@atetubou atetubou deleted the fetch_pack branch January 16, 2018 12:37
dscho added a commit that referenced this pull request Jan 18, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
44db187 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Jan 20, 2018
Merge pull request #1426 from atetubou/fetch_pack
ad72ef3 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Jan 22, 2018
Merge pull request #1426 from atetubou/fetch_pack
4483849 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Jan 22, 2018
Merge pull request #1426 from atetubou/fetch_pack
cc315db 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Jan 22, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
6863db1 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Feb 16, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
7f5be18 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Mar 23, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
2f9960b 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Apr 3, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
8915bcf 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request May 29, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
1b4ff21 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request May 29, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
732f6a8 
fetch-pack.c: enable fscache for stats under .git/objects
PKRoma pushed a commit to PKRoma/git-for-windows that referenced this pull request Jun 22, 2018
@dscho
Merge pull request git-for-windows#1426 from atetubou/fetch_pack
ab43a7a 
fetch-pack.c: enable fscache for stats under .git/objects
PKRoma pushed a commit to PKRoma/git-for-windows that referenced this pull request Jun 22, 2018
@dscho
Merge pull request git-for-windows#1426 from atetubou/fetch_pack
596f1d4 
fetch-pack.c: enable fscache for stats under .git/objects
PKRoma pushed a commit to PKRoma/git-for-windows that referenced this pull request Jun 22, 2018
@dscho
Merge pull request git-for-windows#1426 from atetubou/fetch_pack
79c5bd6 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Aug 22, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
a22e43c 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit to dscho/git that referenced this pull request Aug 22, 2018
@dscho
Merge pull request git-for-windows#1426 from atetubou/fetch_pack
12e9479 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Aug 23, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
8fea209 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Aug 23, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
ea252ec 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Aug 23, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
b51dba0 
fetch-pack.c: enable fscache for stats under .git/objects
jamill pushed a commit to jamill/git that referenced this pull request Aug 28, 2018
@dscho @jamill
Merge pull request git-for-windows#1426 from atetubou/fetch_pack
3c23af0 
fetch-pack.c: enable fscache for stats under .git/objects
jamill pushed a commit to jamill/git that referenced this pull request Sep 5, 2018
@dscho @jamill
Merge pull request git-for-windows#1426 from atetubou/fetch_pack
ddac87d 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Sep 10, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
be1f8e4 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Jan 6, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
2125a47 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Jan 7, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
96df0ba 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Jan 7, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
61418be 
fetch-pack.c: enable fscache for stats under .git/objects
@dscho dscho mentioned this pull request Jan 7, 2025
Merged
dscho added a commit to dscho/git that referenced this pull request Jan 7, 2025
@dscho
Merge pull request git-for-windows#1426 from atetubou/fetch_pack
dbf8e04 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit to dscho/git that referenced this pull request Jan 7, 2025
@dscho
Merge pull request git-for-windows#1426 from atetubou/fetch_pack
c57a360 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Jan 7, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
c2b8aef 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Jan 7, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
06bc961 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Jan 8, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
efb7a7a 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Jan 8, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
1a804b5 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Jan 8, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
0407643 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Jan 8, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
d0f6946 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Jan 9, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
fc4a847 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Jan 9, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
78b0fe4 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Jan 17, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
fa18b41 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Jan 27, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
e03242e 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Jan 27, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
740b813 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Jan 27, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
0130835 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Jan 27, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
1f0c16c 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Jan 27, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
5424f4d 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Jan 28, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
5a9c978 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Jan 28, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
cfa35a7 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Feb 3, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
5da7b68 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Feb 5, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
f8a0127 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Feb 5, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
7f3f30e 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Feb 5, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
b092ed2 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Feb 5, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
b01d121 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Feb 6, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
bd5fa52 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Feb 6, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
aecc24b 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Feb 6, 2025
@dscho
Merge pull request #1426 from atetubou/fetch_pack
b5641c8 
fetch-pack.c: enable fscache for stats under .git/objects
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atetubou @dscho