Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix docs/examples to use new fontSize, remove unsupported font_size #297

Closed
pstoll opened this issue Mar 9, 2018 · 2 comments
Closed

Fix docs/examples to use new fontSize, remove unsupported font_size #297

pstoll opened this issue Mar 9, 2018 · 2 comments
Assignees
@gitbrent
Labels
issue:bug issue:documentation

Comments

@pstoll
Copy link

pstoll commented Mar 9, 2018

This caught me - many examples in the docs/README still use font_size. Spent unnecessary time trying to get basic examples working.

Would you be open to a PR that updated the examples & docs?
@pstoll pstoll changed the title Fix docs/examples to use new fontSizse, remove unsupported font_size Fix docs/examples to use new fontSize, remove unsupported font_size Mar 9, 2018
@gitbrent gitbrent self-assigned this Mar 11, 2018
gitbrent pushed a commit that referenced this issue Mar 11, 2018
Fix for Issue #297
36528f1
@gitbrent
Copy link
Owner

Hi @pstoll,

Dang it!! Thanks for letting me know. The renames must've got lost somewhere in all the 2.0 changes.

I've updated the README and done a project-level search to ensure there's no more floating around anywhere.

gitbrent pushed a commit that referenced this issue Mar 11, 2018
Added Issue #297
f8d1dcd
@pstoll
Copy link
Author

pstoll commented Mar 11, 2018

Awesome, thx!

ericrockey pushed a commit to WeTransfer/PptxGenJS that referenced this issue Mar 24, 2020
Fix for Issue gitbrent#297
8af208e
ericrockey pushed a commit to WeTransfer/PptxGenJS that referenced this issue Mar 24, 2020
Added Issue gitbrent#297
a669c90
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@gitbrent gitbrent

Labels
issue:bug issue:documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pstoll @gitbrent