Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

TypeError: Cannot set property 'lIns' of undefined #879

Closed
CroniD opened this issue Jan 1, 2021 · 1 comment
Closed

TypeError: Cannot set property 'lIns' of undefined #879

CroniD opened this issue Jan 1, 2021 · 1 comment
Assignees
Milestone

Comments

@CroniD
Copy link

CroniD commented Jan 1, 2021

Hi there,

in

slideItemObj.options._bodyProp.lIns = valToPts(slideItemObj.options.margin[0] || 0)
is a check missing for slideItemObj.options._bodyProp.

Best regards

@gitbrent gitbrent self-assigned this Jan 3, 2021
@gitbrent gitbrent added this to the 3.4.0 milestone Jan 3, 2021
@gitbrent
Copy link
Owner

gitbrent commented Jan 3, 2021

A default is added when the object is instantiated in the addTextDefinition() method:

if (!opt._bodyProp) opt._bodyProp = {}

However, I agree that's a poor design.

A local check has been added:
Screen Shot 2021-01-02 at 19 59 37

Thanks @CroniD !

@gitbrent gitbrent closed this as completed Jan 3, 2021
gitbrent added a commit that referenced this issue Jan 3, 2021
gitbrent added a commit that referenced this issue Jan 3, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants