Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Background in master template broken by 3.6.0 #968

Closed
1 of 4 tasks
viral-sh opened this issue Jun 21, 2021 · 1 comment
Closed
1 of 4 tasks

Background in master template broken by 3.6.0 #968

viral-sh opened this issue Jun 21, 2021 · 1 comment
Assignees
Milestone

Comments

@viral-sh
Copy link

Category

  • Enhancement
  • Bug
  • Question
  • Documentation gap/issue

Version

Please specify what version of the library you are using: [ v3.6.0 ]

Please specify what version(s) of PowerPoint you are targeting: [ ]

Expected / Desired Behavior / Question

When we add "path" to the background property of a slide master, it should add the image at the path as background.

  pptx.defineSlideMaster({
    title: "mytitle",
    background: { fill: theme.background1, path: "../bg-image.jpeg" },
    ...

Observed Behavior

Above worked till v3.5.0. But when we upgraded to v3.6.0 it's broken. It triggers repair PPT dialog and does not even add the image.

Steps to Reproduce

  • Create a master and add a background image to it via background.path property.
  • Create a PPT and try to open it.
  • Repair PPT dialog should trigger and background image should not be visible
@gitbrent gitbrent added this to the 3.7.0 milestone Jul 6, 2021
@gitbrent gitbrent self-assigned this Jul 6, 2021
@gitbrent
Copy link
Owner

gitbrent commented Jul 6, 2021

Thanks @viral-sh

The recent changes to the background prop allowed for more than one <p:bg> tag to be created in the slideLayoutN.xml files, which caused the warning.

The API now supports more than 1 background prop correctly.

@gitbrent gitbrent closed this as completed Jul 6, 2021
gitbrent added a commit that referenced this issue Jul 6, 2021
gitbrent added a commit that referenced this issue Jul 6, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants