Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Placeholder left align property needs fixing #417

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

raphael-trzpit
Copy link
Contributor

I had a problem when using a title placeholder in a master slide:

var pptx = new PptxGenJS();
pptx.defineSlideMaster({
  title: 'MASTER_SLIDE',
  objects: [
    { 'placeholder': {
        options: { name:'title', type:'title', x:0.6, y:1.5, w:12, h:5.25, align: 'left' },
        text: '(custom placeholder text!)'
      }
    }
  ]
});
pptx.addNewSlide('MASTER_SLIDE');
pptx.save();

When i open the file, the align property is not precised and the default behavior seems to be centered.
As the left case is ignored, i can't force it :(

@gitbrent gitbrent self-assigned this Oct 12, 2018
@gitbrent gitbrent added this to the 2.4.0 milestone Oct 12, 2018
@gitbrent gitbrent merged commit 0cea814 into gitbrent:master Oct 12, 2018
@gitbrent
Copy link
Owner

Thanks @raphael-trzpit !

@gitbrent gitbrent changed the title fix: Also add the left align property when generating xml paragraph p… Placeholder left align property needs fixing Oct 12, 2018
gitbrent added a commit that referenced this pull request Oct 12, 2018
ericrockey pushed a commit to WeTransfer/PptxGenJS that referenced this pull request Mar 24, 2020
fix: Also add the left align property when generating xml paragraph p…
ericrockey pushed a commit to WeTransfer/PptxGenJS that referenced this pull request Mar 24, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants