Text in slides does not override the bullet master #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it overrides it by default
sgenoud
force-pushed
the
fix/slide-follows-master-bullet-config
branch
from
7c49edd to
941a0ea
Compare
ghost
mentioned this pull request
ankon
reviewed
Apr 1, 2020
Comment on lines
+914
to
+916
| } else if ( textObj.options.bullet === false ){ | ||
| // We only add this when the user explicitely asks for no bullet. | ||
| // Otherwise it can override the master defaults |
There was a problem hiding this comment.
The spaces in the if don't match the existing style (space before '(', space after ')', no space after '(', no space before ')'), and the comment is indented in an odd way.
gitbrent
approved these changes
May 11, 2020
|
Thanks @sgenoud This merged into an old branch, so i've added the code myself. |
gitbrent
added a commit
that referenced
this pull request
May 11, 2020
gitbrent
added a commit
that referenced
this pull request
May 16, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version, it overrides it by default