Fix logic for dataLabelFormat code in Pie and Donut charts #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
cronin4392
force-pushed
the
fix-data-label-format-code-pie-chart
branch
from
f065acf to
e3348fc
Compare
cronin4392
force-pushed
the
fix-data-label-format-code-pie-chart
branch
from
e3348fc to
3922511
Compare
Merged
|
Thanks @cronin4392 ! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently line 280 will overwrite line 279 if the chart type is PIE or DONUT.
What I did was add a conditional check, mimicking the pattern of line 278 to see if
dataLabelFormatcode is set, and I also moved this check up above the non-conditioneddataLabelFormatCode.Fixes #803