Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

more text style: underline/strike/baseline #854

Merged
merged 2 commits into from
Mar 18, 2021
Merged

more text style: underline/strike/baseline #854

merged 2 commits into from
Mar 18, 2021

Conversation

wangfengming
Copy link
Contributor

  • support underline type and color
  • support strike type
  • support baseline

@wangfengming
Copy link
Contributor Author

#811

@wangfengming
Copy link
Contributor Author

image

@gitbrent gitbrent self-assigned this Dec 26, 2020
@gitbrent gitbrent added this to the 3.5.0 milestone Dec 26, 2020
@gitbrent gitbrent merged commit a4675e7 into gitbrent:master Mar 18, 2021
@gitbrent
Copy link
Owner

Thanks @wangfengming !

Screen Shot 2021-03-17 at 21 34 00

gitbrent added a commit that referenced this pull request Mar 18, 2021
@gitbrent
Added Pull #854
bf5e014
@wangfengming
Copy link
Contributor Author

hi @gitbrent , I had made a mistake

{
  	underline?: boolean | string | {
		type?: UnderlineType
		color?: HexColor
	}
}

should be

{
  	underline?: boolean | UnderlineType | {
		type?: UnderlineType
		color?: HexColor
	}
}

@gitbrent
Copy link
Owner

No problem - I changed it a bit during integration:

Screen Shot 2021-03-23 at 23 38 22

@gitbrent gitbrent mentioned this pull request Apr 12, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@gitbrent gitbrent

Labels
enhancement-text
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wangfengming @gitbrent