[FEAT] angleRange & arcThicknessRatio properties for shapes #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ockArc and pie shapes
|
Hi @gitbrent, do you need me to fix those conflicts ? |
|
@apresmoi - yes, please patch the src/*. files instead of dist. thanks. |
apresmoi
force-pushed
the
feature/angle-range
branch
from
306dce4 to
1884168
Compare
|
@gitbrent - There it is, I've force-pushed only with changes inside src/ |
gitbrent
approved these changes
Dec 24, 2020
|
Thanks @apresmoi ! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everybody.
I wanted to have this two options to be able to play around with the arc, blockArc and pie shapes. In the current version there isn't the possibility to set the angle range of these shapes.
Maybe a better solution for the future could be adding a type for each of the supported properties with all of their supported variables.
Hope you like it.
Thank you !